tasvideos icon indicating copy to clipboard operation
tasvideos copied to clipboard

From forum, "New Post" > "Cancel" takes you back to first page

Open YoshiRulz opened this issue 1 year ago • 2 comments

Same with "Quote".

Can it history.back() instead?

YoshiRulz avatar Dec 05 '24 01:12 YoshiRulz

We probably don't want history.back() ever. First, it only works with JS enabled, and we want to support basic functionality without JS anyway, so that'd be double the effort and maintenance. And secondly, it's possible to come from any page at all, and it'd be awkward to click a tasvideos button and be redirected to a random other website. There might not even be a back page, making the button do nothing at all. Thirdly, it's an uncommon behavior in general. If I click something and it redirects me, I want to be able to use my browser back button to go back. But doing this actually hijacks my back button, or at least it feels like it, because suddenly my back button doesn't return me to the page I pressed "Cancel" on.

Masterjun3 avatar Dec 05 '24 09:12 Masterjun3

With some other mechanism then. Login uses the returnUrl queryparam.

YoshiRulz avatar Dec 05 '24 22:12 YoshiRulz