tasvideos icon indicating copy to clipboard operation
tasvideos copied to clipboard

A missing framerate entry causes submission to break (and also breaks all pages trying to show submission)

Open Masterjun3 opened this issue 2 years ago • 2 comments

When a submission is created, (and our parser doesn't override the framerate) we match the framerate exactly to the system and region.

https://github.com/TASVideos/tasvideos/blob/b693cc7aefe18a42b899181401d3d20e3682e490/TASVideos.Core/Services/QueueService.cs#L435-L440

If this doesn't exist, the field is empty and breaks the title generation.


To avoid breaking the site, we have to either set a default framerate if the framerate wasn't found, or we have to make sure that fitting framerate entries are always created when creating a new system.

Masterjun3 avatar Mar 31 '23 21:03 Masterjun3

I can't remember why we didn't have a suitable framerate in that case. What submission was it?

vadosnaprimer avatar Feb 02 '24 13:02 vadosnaprimer

I think the region was set to "World" without a framerateoverride, but we only had "NTSC" and "PAL" regions, or something like that.

Masterjun3 avatar Feb 02 '24 14:02 Masterjun3