fceux icon indicating copy to clipboard operation
fceux copied to clipboard

Extremely inaccurate triangle pitch in VS. Excitebike FDS (not arcade version)

Open riggles1 opened this issue 2 years ago • 4 comments

Start VS. Excitebike.fds and on disk B start the original excite mode, in both the menu and gameplay on the playback of the triangle is at a wrong pitch.

https://cdn.discordapp.com/attachments/611876466187304960/1100168777976533132/Excitebike_FDS_incorrect_pitch.mp3

How it should sound: https://cdn.discordapp.com/attachments/611876466187304960/1100168856116412576/Excitebike_FDS_correct_pitch.mp3

I hope this issue gets some priority as it's a pretty big one and I love this emulator, what other fds games have the sound emulation affected like this?

riggles1 avatar Apr 24 '23 21:04 riggles1

is it really the triangle channel? i know FDS audio mod is missing or incomplete hence some "wierdness" in FDS expansion audio (like zelda's death effect).

Mednafen, using a port of fceux has better (if not accurate) FDS audio emulation, maybe someone can port it or something or use it as reference to fix fceux FDS expansion audio emulation.

negativeExponent avatar May 07 '23 02:05 negativeExponent

Not the dedicated triangle channel, but the FDS channel that for this case makes a triangle sound for the bassline. Porting over that would be amazing as it's the biggest drawback with fceumm+fceux currently, as bad as even just going on Youtube and watching the most viewed FDS VS. Excitebike gameplay will give you videos where the pitch off.

(other niceties for fceux/mm in the future would be audio volume settings for all the channels, and automatic FDS side swapping, hopefully some day, either case, the FDS pitch issue seems pretty urgent)

riggles1 avatar May 07 '23 15:05 riggles1

Here the same problem in punes

https://github.com/punesemu/puNES/issues/295

fixed in this comment

https://github.com/punesemu/puNES/commit/f707fe41669cd2cb06d730f0cc32fecd3460c65a

vicde avatar May 07 '23 18:05 vicde

ive just blindlt ported mdfn's fds audio code into fceux and indeed sounds are better including Excite Bike. not sure how accurate it is but it sounds better. sadly i cant get it to work when soundquality is set to low. hope someone would look into is as im not knowledgeable with how internerla hardware works ....

negativeExponent avatar Aug 29 '23 12:08 negativeExponent