BizHawk icon indicating copy to clipboard operation
BizHawk copied to clipboard

[🐧] I can't see anything! (Regression)

Open cD1rtX3 opened this issue 3 months ago • 9 comments

Summary

Since 2.11, all normal text in dialogues is unreadable.

Repro

  1. Open a dialogue.

Host env.

  • BizHawk 2.11; Ubuntu 24.04.2 LTS; Intel/Intel

Screenshots:

Image

cD1rtX3 avatar Sep 25 '25 03:09 cD1rtX3

Dialogue in 2.10:
Image

cD1rtX3 avatar Sep 25 '25 03:09 cD1rtX3

Can you bisect? Even if I had an idea of what commit could have done this, I can't repro; theming is broken for me in both releases (and both are working on my other machine).

YoshiRulz avatar Sep 25 '25 14:09 YoshiRulz

From linked thread, if your issue is the same then https://github.com/TASEmulators/BizHawk/commit/a64d7627ce9348e5dcade6941787d59ebc286cae may be the cause? @Morilli How can we conditionally use the old scaling mode for Linux only?

YoshiRulz avatar Sep 25 '25 17:09 YoshiRulz

sigh... previously for windows, AutoScaleFactorX was 1 and AutoScaleFactorY was 1. After that commit, AutoScaleFactorX is 1 and AutoScaleFactorY is 1. Naively I didn't expect that to differ for linux. Perhaps using AutoScaleMode.Font is actually the correct thing to do if we want to ensure things are sized properly for contained text.

Morilli avatar Sep 25 '25 18:09 Morilli

My internet is not good enough to download and test that PR 😔

cD1rtX3 avatar Sep 27 '25 02:09 cD1rtX3

It's just 80MBs, same as release... https://github.com/TASEmulators/BizHawk/actions/runs/18020954575/artifacts/4110492392

vadosnaprimer avatar Sep 27 '25 07:09 vadosnaprimer

Report from Discord of a user who switched to a dev build in order to fix the binds dialog. They found that, on this other dialog: https://github.com/TASEmulators/BizHawk/blob/d2a604954be95d3a2006cae6d24ad0f5ceaaaf5c/src/BizHawk.Client.EmuHawk/tools/ToolManager.cs#L713-L716 ...the buttons are blank still, which is bad news since that's the generic one, not something we control: https://github.com/TASEmulators/BizHawk/blob/d2a604954be95d3a2006cae6d24ad0f5ceaaaf5c/src/BizHawk.Client.EmuHawk/MainForm.cs#L4528 https://github.com/TASEmulators/BizHawk/blob/d2a604954be95d3a2006cae6d24ad0f5ceaaaf5c/src/BizHawk.Client.EmuHawk/DialogControllerWinFormsExtensions.cs#L35

edit: A different user found that buttons in Lua-generated forms are also blank, and GTK_DATA_PREFIX='' doesn't help.

YoshiRulz avatar Nov 04 '25 20:11 YoshiRulz

It's just 80MBs, same as release... https://github.com/TASEmulators/BizHawk/actions/runs/18020954575/artifacts/4110492392

I see. I was trying to download the entire source code, which is over 400 MB.

cD1rtX3 avatar Nov 12 '25 16:11 cD1rtX3

It's just 80MBs, same as release... https://github.com/TASEmulators/BizHawk/actions/runs/18020954575/artifacts/4110492392

This version seemed to fix the issue on my machine (at least in the dialogue in the screenshot)! Sorry I am so late to the party.

cD1rtX3 avatar Nov 13 '25 14:11 cD1rtX3