BizHawk icon indicating copy to clipboard operation
BizHawk copied to clipboard

Key priority setting doesn't compare individually mapped keys to key combinations

Open TakuikaNinja opened this issue 7 months ago • 0 comments

Summary

If keys mapped to separate inputs conflict with a hotkey combination, the hotkey is always prioritised regardless of the key priority setting. This is very counter-intuitive, especially on cores for computers where one may attempt to recreate the keyboard mapping from another emulator.

Repro

The steps here use ZXHawk as the issue is most apparent here. It should occur in other cores, too.

  1. Load ZXHawk and a game in 48K mode, you should be put into a BASIC prompt
  2. Set the key priority to "input overrides hotkeys"
  3. In the controller settings, assign Ctrl and O to Key Symbol Shift and Key O respectively
  4. Press the keys together - the open file hotkey (Ctrl+O) is recognised instead of the inputs (correct input should put ; in the BASIC prompt as it's Symbol Shift+O)

Host env.

The environment shouldn't matter as I've been told the input handling code is OS-agnostic.

  • BizHawk 2.9.1; EndeavourOS; AMD (Me)
  • BizHawk 2.9.1; Windows (CasualPokePlayer)

TakuikaNinja avatar Jan 10 '24 04:01 TakuikaNinja