GBA trace logger's results are mislabeled

[RetroEdit]

Summary

For GBA, the listed PC addresses to the left are off by 2 in Thumb mode, and off by 4 in ARM mode.

For instance, for a Thumb instruction on address 08009284, it will be labeled as 08009282.

This also affects how certain load-related instructions are interpreted, since the trace logger attempts to infer what the loaded value will be for loads from the ROM.

~~I believe similar issues might be true for other consoles as well, but I haven't checked recently.~~

(2023-10-14): My current suspicion is that this might be a legacy carryover from VBA-Next where mGBA has different behavior, but I haven't looked into the code or the repo history yet. It sort of makes sense if they have different pipeline sizes.

Host env.

• BizHawk 2.9.1