BizHawk icon indicating copy to clipboard operation
BizHawk copied to clipboard

Published 20 hours ago • verified publisher icon TASEmulators

Simplify SGB related UIs (and make it possible to use SGB under Gambatte link)

Open Fortranm opened this issue 3 years ago • 3 comments
trafficstars

https://en.wikipedia.org/wiki/Super_Game_Boy#Super_Game_Boy_2

The Super Game Boy 2 was released exclusively in Japan in 1998. Additions included a link port to allow a user to access two-player mode via the link cable...

Currently, the SGB mode of Gambatte has to be turned on via Config > Cores > GB in SGB instead of in the sync setting and cannot be used in GB Link as a result.

This PR does three things related to SGB:

  1. SGB is added (or rather, merged in) as a Console Mode option for Gambatte. image

  2. "GB in SGB" check box and SGB core picker are removed and the BSNES cores are added under the GB core picket. GB/GBC games will load under SGB mode of the corresponding BSNES core if one of those options are chosen. image

  3. As a result of the first change (with addition adjustments), it is now possible to use SGB mode in Gambatte Link too. image image Each SGB core can have up to 4 controllers linked to it. Note that the tab parsing process is currently hardcoded to categorize every item that starts with "Px " under the tab "Player x" and everything else under "Console". There have been suggestions to use "Console x" for a core in link mode but that requires enough refactoring to be considered a separate task IMO.

Fortranm avatar Jun 19 '22 09:06 Fortranm

There's some issues here:

  1. I'm not sure if this UI is any better than before. The old UI seems more intuitive imo (still not the best of course)
  2. This change was mainly to get GBL in for SGB2 from what I know (which yes, the SGB2 did have a link port). However, getting it working requires extra effort here. The 4 players in SGB2 per Gambatte core makes controller handling a mess (I'm not sure if this is PR is exactly the best solution here). SGB Borders are also an issue as they are absent in the current implementation, not to mention SGB sound, which is missing here.

CasualPokePlayer avatar Jun 19 '22 09:06 CasualPokePlayer

SGB borders can now be displayed in GBL mode. Note that all borders will be displayed when any of the SGB cores have the Display Border option enabled. image (the second and fourth cores are in GBA mode here)

Fortranm avatar Jun 21 '22 09:06 Fortranm

Unable to reproduce this, since it is impossible to load GambatteLink for me.

getCursorsExe avatar Jul 03 '22 12:07 getCursorsExe