BizHawk icon indicating copy to clipboard operation
BizHawk copied to clipboard

DSi firmwares have no checksum

Open BegaDrive opened this issue 2 years ago • 3 comments

Bizhawk v2.8 windows x64

bh

BegaDrive avatar Feb 20 '22 10:02 BegaDrive

For technical reasons, we can't put one or more "correct" hashes there. (It probably shouldn't be the all-zeroes hash though @CasualPokePlayer).

YoshiRulz avatar Feb 20 '22 11:02 YoshiRulz

NAND is per-console unique along with DSi BIOS files due to encryption. There is not one true hash to them. All zeros is just a filler hash.

CasualPokePlayer avatar Feb 20 '22 11:02 CasualPokePlayer

The missed detail here is actually that it's reporting the same exact info for all 4 DSi firmware files, even tho in the code they have different info but the hash is dummy. Still a problem on latest master.

vadosnaprimer avatar Jun 02 '22 18:06 vadosnaprimer

Seems the issue is ultimately due to those entries taken from FirmwareFilesByHash. Which is a bit obvious in retrospect. Generally this isn't that bad as that hash is not intended to match with any file. It screws up here however as the last thing with the dummy hash is what's actually in the Dict (so DSi NAND) and thus what you see is that info for all firmwares with that hash.

CasualPokePlayer avatar Aug 28 '22 09:08 CasualPokePlayer