Tassilo Karge

I will make some simplifications to the private methods, that should reduce code duplication.

The reason I split the methods is that the method `getSitemapEvents` https://github.com/openhab/openhab-core/blob/81f2bd9366d3f937da892ac704671207fce5e10c/bundles/org.openhab.core.io.rest.sitemap/src/main/java/org/openhab/core/io/rest/sitemap/internal/SitemapResource.java#L346-L349 allows null as pageId. If I unsplit the whole implementation by allowing null pageIds throughout, omitting the pageId...

I improved the code as suggested

> There seems to be an issue with spotless yes, it does not like formatting in conditions :D Fixed that.

@J-N-K and @lolodomo I think the tests fail due to my code deduplication, I'll fix that today. It was a pleasure working on finalizing this the last couple of days,...

The test fails because the subscriptionService is just a mock, I need to properly instantiate it and mock its itemUIRegistry in the test.

> You can also keep the mocked `subscriptionService` but that would defeat the purpose of the test, since an important part of the logic resides in collectWidgets

@J-N-K the test issues have been resolved.

> I am going to fix that. Thank you very much, I wasn't aware that the method was public api. Maybe I should re-add the legacy method but deprecate it...

The maintainers are currently in the process of recovering their watchId app identifier with Apple and not able to release as far as I know. Until then, I would like...