launcher icon indicating copy to clipboard operation
launcher copied to clipboard

quicktests broken, LAUNCHER_JOB_FILE missing

Open fzeiser opened this issue 4 years ago • 2 comments

The quicktests in test at e00ae54 are broken, as the LAUNCHER_JOB_FILE is missing.

https://github.com/TACC/launcher/blob/e00ae54505528a0eed0a8286961ed709dc19fadd/tests/quicktest#L13 should potentially be default_work_file?

and https://github.com/TACC/launcher/blob/e00ae54505528a0eed0a8286961ed709dc19fadd/tests/quicktest2#L13 could be replaced by something like .../helloworld_multi_output

fzeiser avatar Jul 28 '20 07:07 fzeiser

Or it the example should contain a clear description on that one has to include a commands file, as below; however, this is not as convenient for a test example https://github.com/TACC/launcher/blob/e00ae54505528a0eed0a8286961ed709dc19fadd/extras/batch-scripts/job_script_test.slurm#L7-L11

Is there something I*m missing out?

  • here I guess the path should be updated: https://github.com/TACC/launcher/blob/e00ae54505528a0eed0a8286961ed709dc19fadd/extras/batch-scripts/launcher.slurm#L32 to ../examples/helloworld_multi_output

fzeiser avatar Jul 28 '20 07:07 fzeiser

Note that the verifying-installation section, https://github.com/TACC/launcher#verifying-installation, refers to quickstart, not quicktest.

fzeiser avatar Jul 28 '20 07:07 fzeiser