phonebook icon indicating copy to clipboard operation
phonebook copied to clipboard

Published 20 hours ago • verified publisher icon T-Systems-MMS

fix: Handle null Telephone Numbers (#579)

Open T2brozz opened this issue 4 years ago • 8 comments

Description Changed return value from '' to No phone number Issue Closes #579

T2brozz avatar Oct 26 '20 19:10 T2brozz

We are following Conventional Commit Format. Please make sure that your Pull Request title does conform to this format, otherwise it might not be released.

github-actions[bot] avatar Oct 26 '20 19:10 github-actions[bot]

/azp run T-Systems-MMS.phonebook-preview

mschwrdtnr avatar Oct 28 '20 10:10 mschwrdtnr

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 28 '20 10:10 azure-pipelines[bot]

Hey @T2brozz, thanks for your first contribution 🎉

We will check the code and take a look at the demo :)

mschwrdtnr avatar Oct 28 '20 10:10 mschwrdtnr

@DanielHabenicht preview still not working?

mschwrdtnr avatar Oct 28 '20 13:10 mschwrdtnr

@DanielHabenicht preview still not working?

nope, again. Seems like azure Kubernetes pricing has increased leading to the cluster not being up anymore.

DanielHabenicht avatar Oct 28 '20 14:10 DanielHabenicht

Wait. Did I made a misstake?

T2brozz avatar Oct 28 '20 15:10 T2brozz

Wait. Did I made a misstake?

no, but normally we could see what you did in our demo environment which is populated for each Pull Request. Unfortunately, that's not possible because it is getting to expensive. So we will have to preview it locally. I will have a look later.

DanielHabenicht avatar Oct 28 '20 16:10 DanielHabenicht