phonebook
phonebook copied to clipboard
T-Systems-MMS
feat(service worker): add service worker functionality
Do not merge till at least 29.07 in order to auto uninstall the old service worker in our company.
There is still a bug: https://github.com/angular/angular/issues/23613
Caused by us changing the environment variables in the index.html, possible solutions:
- remove the index.html hash from ngsw.json
- recalculate the hash.
@mschwrdtnr @paule96 @marcuskrahl @FrankLambrette please have a look at the PR-Preview and look out for issues that might come from the service worker (outdated info, double network requests, if it is working offline, for both languages etc.)
Please write back if any issues arise. If not we can merge and finally it will work for both English and German and completely offline 🎉 .
@DanielHabenicht could you please explain, how the page should work offline, so what should load and so on? If I set the network settings in chrome dev tools to offline, the page wont load any content anymore.
![azure-pipelines[bot] avatar](https://avatars.githubusercontent.com/in/9426?v=4 "Published by a pub.dev verified publisher"){kind=small}
@DanielHabenicht could you please explain, how the page should work offline, so what should load and so on? If I set the network settings in chrome dev tools to offline, the page wont load any content anymore.
Will test it after your answer :)
I already described what to test here
look out for issues that might come from the service worker (outdated info, double network requests, if it is working offline, for both languages etc.)
Everything should work as if you are online. Report back everything that does not work.
@DanielHabenicht does the page needs a initial connection for working offline afterwards?
Not evrything can be loaded properly:
Rooms are not loading, so no content is shown if offline.
@DanielHabenicht does the page needs a initial connection for working offline afterwards?
Does the page load if you are offline or not?
Not evrything can be loaded properly:
Rooms are not loading, so no content is shown if offline.
That's ok, dynamic content can't be preloaded. But everything you already searched for will be there.
@DanielHabenicht does the page needs a initial connection for working offline afterwards?
Does the page load if you are offline or not?
If I reload the page with connection set to offline, it is not loading. But if I dont reload, evrything exept the rooms is loaded fine
Blocked by Angular i18n, depending on $localize being runtime or AOT compiled.