William Song comments

Results 19 comments of


                                            William Song

LEAK: ByteBuf.release() was not called before it's garbage-collected

Hi, is this issue solved? We observed the same LEAK message recently, and after turning off retry, it disappears.

RATIS-1557. Linearizable Leader Read-Only Request Implementation

@szetszwo @codings-dan This PR is a draft for [Linearizable Reads](https://issues.apache.org/jira/browse/RATIS-1557), please take a look. Any suggestions on overall design or code details would be great!

RATIS-1557. Linearizable Leader Read-Only Request Implementation

@szetszwo I've made corresponding changes. Also I added some doc in getReadIndex() and readOnlyAsync().

RATIS-1557. Linearizable Leader Read-Only Request Implementation

@szetszwo, Thanks for the review. 1. Raft section 6.4 says a single round of heartbeats can answer any number of read-only requests that accumulate, so we may not have to...

RATIS-1557. Linearizable Leader Read-Only Request Implementation

@szetszwo I fixed the review issues. Please take a look at the code again. Thanks!

RATIS-1557. Linearizable Leader Read-Only Request Implementation

@szetszwo Thanks for the review! I'll add `triggerHeartbeat` & batching mechanism after https://github.com/apache/ratis/pull/706 is merged.

RATIS-1557. Linearizable Leader Read-Only Request Implementation

@szetszwo OK, I'll split it into subtasks.

RATIS-1557. Linearizable Leader Read-Only Request Implementation

This PR will be split into subtasks, so I'll just close it now.

[Feature] [SWCK] Add doc for BanyanDB CRD and Controller

@dashanji Sure! I'd love to. Please assign it to me.