Émile Fugulin comments

Results 702 comments of


                                            Émile Fugulin

feat: Add execFile Support

@richarddavison Do you want to take that on or not?

SimplexStream does not close other half on drop

@Darksonn a compromise might be to make a sync shutdown method public so we can make our own wrapper with a Drop method.

Any solution equivalent to NodeJS proxy-chain?

There is not, it would be a good addition sister crate but I dont have time to code this. If this is important for you please send a PR.

Example of C class extending JS class

Yes sorry `Uint8Array`. That would work for the prototype, I probably also need something for the constructor to call the parent one.

Example of C class extending JS class

I tried to use `JS_GetClassProto` with the class id of `Uint8Array` (12 at the moment), but it always returns an empty prototype for some reason. `JS_GetPrototype` on the globals does...

Example of C class extending JS class

@chqrlie If you have time, still looking for guidance on it

Example of C class extending JS class

I guess no resolution on this one

Example of C class extending JS class

The prototype can get you the parent prototype but calling the constructor to create a subclass is really not self evident. Same idea to make instanceof work correctly. Anyway rquickjs...

Bytes::make_mut

Can we also pack into this PR the equivalent of `Arc::make_mut` @rklaehn ? Because its nice to be able to try it, but you are kind of stuck if you...

Bytes::make_mut

I made a zero-copy (if possible) version to convert directly to mut without going through a `Vec` first.