Émile Fugulin

Results 704 comments of Émile Fugulin

The code is fine, the problem is enabling the dependency in `Cargo.toml`. This is not possible: ```toml [features] default = ["encoding"] encoding = [] # ... other features not related...

Same. AFAIK the only alternative is what I have done currently with `encoding-simd`, its ugly but it works.

I will implement the separate crate like discussed, I will bundle the `asm` with the `simd` feature. Crates like `md-5` don't compile at all on windows when they use `asm`...

Too much changed, I think it should be easier to do with the new structure

Hey I am pitching in since I started working on a utils crate for rquickjs (https://github.com/DelSkayn/rquickjs/pull/319). The goal is to eventually recreate all the api we expect from node/deno for...

I will post it here since I am in charge of it. Here is the discord: https://discord.com/invite/pyMppMngYU

One thing I wanted to mention is that modules should be more independent than they are right now. For example the URL module cant be evaluated at the moment if...

Yeah probably but for a user I should not have to know the internals of the modules to know that the http module must be included for the URL module...

Alright I started work on that. @richarddavison when you have 2s, can you join the discord :) I agree on the refactor of the module builder, but this can be...

@nabetti1720 Yup totally. The fs was the original module to test and I will port others. I do think I want to work on a better Module trait first like...