strimzi-kafka-cli icon indicating copy to clipboard operation
strimzi-kafka-cli copied to clipboard

add tab completion

Open mabulgu opened this issue 4 years ago • 4 comments

mabulgu avatar May 12 '21 11:05 mabulgu

We can use typer plus it is similar to click and has rich addon for colors plus shell completion ability. (related to #69) if "add colors means terminal color"

https://typer.tiangolo.com/

onuralpszr avatar Sep 22 '23 22:09 onuralpszr

We can use typer plus it is similar to click and has rich addon for colors plus shell completion ability. (related to #69) if "add colors means terminal color"

https://typer.tiangolo.com/

I dont think I want to replace click TBH. There are a lot of fancy tools but I am trying to be a bit picky with the selections as maintenance has costs you know:) The coloring thing is not vital but completion is (but its not sth I want to do before the beta tho) doable with click as well. Consider these kinda open issues as spikes. And sorry for the non detailed issues and their explanations. I had noone but myself working on this project so far.

mabulgu avatar Sep 24 '23 18:09 mabulgu

We can use typer plus it is similar to click and has rich addon for colors plus shell completion ability. (related to #69) if "add colors means terminal color" https://typer.tiangolo.com/

I dont think I want to replace click TBH. There are a lot of fancy tools but I am trying to be a bit picky with the selections as maintenance has costs you know:) The coloring thing is not vital but completion is (but its not sth I want to do before the beta tho) doable with click as well. Consider these kinda open issues as spikes. And sorry for the non detailed issues and their explanations. I had noone but myself working on this project so far.

For maintenance "typer" is very well "okay" :) For you it should be fine I guess. Plus you already have issue with "click" because I had to keep old version for sake of "tests" so we already need to replace "click" version to higher plus fix tests because your exist codes changed. I was already playing with typer in here and used before so, maybe I can send PR for that too :)

onuralpszr avatar Sep 24 '23 18:09 onuralpszr

My point was more general regarding the maintenance, not for Typer. +n tool means 2^n complexity so I might want to skip that for now. We can visit the coloring later on. For yet another CLI tool, I did a lot of reseach in the past and to me click was the best back then. There are lots of stuff in the project to be updated to I would want to pass it right now I guess. click is more than enough right now:)

mabulgu avatar Sep 24 '23 19:09 mabulgu