idisc icon indicating copy to clipboard operation
idisc copied to clipboard

Published 20 hours ago • verified publisher icon SysCV

Setting cross_attn_{i+1}_d{1} but not cross_attn_{i+1}_d{j} on purpose or typo in id_module.py?

Open yuliangguo opened this issue 8 months ago • 0 comments

Dear author,

When I dig deeper into the code, I found this rather confusing. The iterature seems to repeated create d{1} rather than d{j}. Would like to confirm is this setup on purpose or a typo?

https://github.com/SysCV/idisc/blob/5d6cea2f0e5236701b2dfd6dac89cde13a328d33/idisc/models/id_module.py#L180C1-L181C1

yuliangguo avatar Jun 11 '24 04:06 yuliangguo