yeast-GEM icon indicating copy to clipboard operation
yeast-GEM copied to clipboard

Feat-Volatiles produced by S. cerevisiae

Open feiranl opened this issue 3 years ago • 3 comments

Description of the issue:

  • Model expansion to cover more volatiles as metabolites.

I hereby confirm that I have:

  • [ ] Tested my code with all requirements for running the model
  • [ ] Done this analysis in the main branch of the repository
  • [ ] Checked that a similar issue does not exist already
  • [ ] If needed, asked first in the Gitter chat room about the issue

feiranl avatar Jan 31 '22 21:01 feiranl

Reactions from this paper should also checked and curated into the Yeast8?

feiranl avatar Mar 29 '22 09:03 feiranl

@wtscott31 That's your paper, is this included in #300 ?

edkerk avatar Mar 29 '22 09:03 edkerk

Yes I already added pathways related to my paper into Yeast8 in PR #248 https://github.com/SysBioChalmers/yeast-GEM/pull/248 This new PR is based on new literature about sulfur metabolism.

On Tue, Mar 29, 2022 at 11:14 AM Eduard Kerkhoven @.***> wrote:

@wtscott31 https://github.com/wtscott31 That's your paper, is this included in #300 https://github.com/SysBioChalmers/yeast-GEM/pull/300 ?

— Reply to this email directly, view it on GitHub https://github.com/SysBioChalmers/yeast-GEM/issues/296#issuecomment-1081627015, or unsubscribe https://github.com/notifications/unsubscribe-auth/AISXXYTF6M5W43KTJADDBQLVCLCW7ANCNFSM5NHMNASQ . You are receiving this because you were mentioned.Message ID: @.***>

wtscott31 avatar Oct 11 '22 07:10 wtscott31

I am joining @Hendrik-iAMB to add volatile reactions to the model on a new fork. Some questions:

  1. Should I really use the main branch in my fork as mentioned by @feiranl? The developers guide recommends a develop-branch.
  2. I would like to work in Python and add reactions to get a new xml. How do I generate the corresponding yml and txt file versions?
  3. How should I choose new reaction and metabolite IDs?

uliebal avatar Oct 24 '22 14:10 uliebal

I am joining @Hendrik-iAMB to add volatile reactions to the model on a new fork.

Excellent!

1. Should I really use the `main` branch in my fork as mentioned by @feiranl? The developers guide recommends a `develop`-branch.

Since I can't find the context in which @feiranl might have said this, I can only second the developers guide even if develop is quite close to main at the moment, that is bound to change.

2. I would like to work in Python and add reactions to get a new `xml`. How do I generate the corresponding `yml` and `txt` file versions?

Perhaps a Matlab user can contribute to your fork by using the corresponding function in RAVEN (exportYaml, exportModel).

3. How should I choose new reaction and metabolite IDs?

That's a great question to have, and what I believe to be the right answer doesn't have its place here. The next best thing that I can recommend is to "borrow" an identifier from another database (like it was done with BiGG ids). This would defer the renaming of the ids to an indefinite future (a great time would be the next major release).

mihai-sysbio avatar Feb 06 '23 11:02 mihai-sysbio

Included in #339

edkerk avatar Jul 15 '23 15:07 edkerk