Human-GEM icon indicating copy to clipboard operation
Human-GEM copied to clipboard

rename model structure in Matlab

Open mihai-sysbio opened this issue 3 years ago • 3 comments

Description of the feature

As a new person to Human-GEM, I want the Matlab model structure to be named something intuitive and easy, so that the code that I write makes more sense.

Expected feature/value/output:

Currently, the Matlab structure of the model is named ihuman. While this is for historical reasons, it does no longer serve a purpose. Moreover, it adds inconsistency, as there is no explanation/justification for this name choice, and it not used in other places. Therefore, what is expected is a more sensible name choice.

I hereby confirm that I have:

  • [x] Tested my code on my own computer for running the model
  • [x] Done this analysis in the main branch of the repository
  • [x] Checked that a similar issue does not exist already

mihai-sysbio avatar Aug 01 '22 20:08 mihai-sysbio

what do you mean by a more sensible name

haowang-bioinfo avatar Aug 02 '22 07:08 haowang-bioinfo

Instead of following the legacy naming scheme that seems no longer relevant, a more sensible choice would be something that is familiar for the user, intuitive and Matlab compatible such as human_gem or HumanGEM. Other ideas are to base it on hsa or hsapiens.

mihai-sysbio avatar Aug 02 '22 08:08 mihai-sysbio

@mihai-sysbio thanks for the ideas. HumanGEM seems to be a better name than human_gem , what do you think?

haowang-bioinfo avatar Aug 02 '22 08:08 haowang-bioinfo