SPARK icon indicating copy to clipboard operation
SPARK copied to clipboard

pull request

Open shelltdf opened this issue 4 years ago • 2 comments

pull request

shelltdf avatar Jan 26 '21 14:01 shelltdf

Thanks for the participation !

As is, this PR cannot be accepted. Please separate it in several PRs:

  • one for your CMake improvements. BTW, there are several things that I don't really like:
    • what is "NIUBI" ?
    • the whole CMake config is currently obsolete, it would be nice to redo it entirely
    • no INSTALL rules, please
  • explain why going from size_t to unsigned int ?
  • changing the demos binaries should be an entire separate commit
  • don't change emit because of Qt. This change will always be refused; instead, please tell Qt not to define emit (and also signal btw)
  • why remove virtual ?

Synxis avatar Jan 26 '21 17:01 Synxis

in 32bit system size_t is 32bit. in 64bit system is 64bit. but *.spk file used on 32 and 64bit system.

shelltdf avatar Jan 27 '21 05:01 shelltdf