synthetix icon indicating copy to clipboard operation
synthetix copied to clipboard

ArbRewarder: max_delay does not restrict transaction execution time

Open ItsNickBarry opened this issue 4 years ago • 0 comments

https://github.com/Synthetixio/synthetix/blob/472d9111f3db69cae3265866ebe2c235be31bc69/contracts/ArbRewarder.sol#L144

Because now is referenced within the ArbRewarder contract, its value will be set when the transaction is included in a block. And because ethToTokenSwapInput is called within the same transaction, it is always executed within the same block. Therefore, the addition of max_delay does nothing to restrict the actual execution time of the transaction.

Please correct me if I am mistaken.

ItsNickBarry avatar Dec 17 '19 00:12 ItsNickBarry