synthetix icon indicating copy to clipboard operation
synthetix copied to clipboard

Feature/next price qol

Open davidvuong opened this issue 2 years ago • 1 comments

Part 1/2 of Next-Price QoL changes. This PR includes:

  1. The addition of 2 events NextPriceOrderCancelled and NextPriceOrderExecuted as well as the removal of NextPriceOrderRemoved
  2. and also a new canExecuteOrCancel view

Both changes were made against contracts/PerpsOrdersV2NextPriceMixin.sol with no change to existing functionality. Tests have been updated to reflect event changes and the addition of a new view.

More details can be found as comments in the codebase.

davidvuong avatar Aug 30 '22 00:08 davidvuong

Codecov Report

Merging #1888 (f65a43a) into perps-features-updates (8aa8beb) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@                   Coverage Diff                   @@
##           perps-features-updates    #1888   +/-   ##
=======================================================
  Coverage                   95.84%   95.84%           
=======================================================
  Files                         112      112           
  Lines                        2765     2768    +3     
  Branches                      844      845    +1     
=======================================================
+ Hits                         2650     2653    +3     
  Misses                        115      115           
Impacted Files Coverage Δ
contracts/PerpsOrdersV2NextPriceMixin.sol 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 30 '22 00:08 codecov[bot]