synthetix-v3 icon indicating copy to clipboard operation
synthetix-v3 copied to clipboard

Fix the unrecognized custom error issue in tests (probably hardhat error)

Open leomassazza opened this issue 4 years ago • 2 comments

And remove the extra check in assert-revert.js when is fixed

Related to https://github.com/nomiclabs/hardhat/issues/1996

leomassazza avatar Oct 22 '21 14:10 leomassazza

Checked if this was fixed today, but seems like not yet. I asked to bump the priority tho.

eternauta1337 avatar Nov 25 '21 18:11 eternauta1337

Had another look at this today. Still, no fixes from hh it seems.

Opened a PR to be a bit more explicit: https://github.com/Synthetixio/synthetix-v3/pull/667

The problem still seems to be that the first time tests are run errors are not parsed, but runs fine the second time.

eternauta1337 avatar Dec 20 '21 17:12 eternauta1337