synthetix-mintr icon indicating copy to clipboard operation
synthetix-mintr copied to clipboard

Select the ledger derivation path before getting the addresses

Open 0xclem opened this issue 5 years ago • 4 comments

Right now we default the derivation path to m/44/60/0/0 and grab the addresses, which might be frustrating for Live derivation path users.

Let's default the dropdown with "Please select a derivation path" and once it's chosen we run the getNextAddresses() function.

We could also have a save button to remember the user's choice next time (saving it in the cache).

0xclem avatar Nov 22 '19 04:11 0xclem

I would think defaulting is fine and then everytime they pick we save it to localstorage?

Up do you, I can obv make it default to unselected

0xjocke avatar Nov 22 '19 23:11 0xjocke

@bachstatter Yeah I guess it's fine loading the wrong derivation path for the first time.

0xclem avatar Nov 25 '19 03:11 0xclem

@bachstatter though I just found out if I refresh and "ledger live" is selected by default, it will load the wrong derivation path.

0xclem avatar Nov 25 '19 03:11 0xclem

Maybe we could write some tests to make sure we init Trezor and Ledger with the correct params, regarding the derivation path, what is save in the cache...etc. What do you think?

0xclem avatar Nov 25 '19 04:11 0xclem