Support Phantom wallet

[maximgeerinck]

Motivation and context

Add support for phantom wallet.

List of current features:

• Connect wallet
• Sign message
• Cancel signing
• Wallet setup
• Copy eth address

EXTRA:

• Multiple providers: Can use metamask and phantom together in 1 session using the PROVIDERS environment variable
• Supports versions using @

PROVIDERS=phantom,[email protected] npx playwright test

TODO:

• [x] Phantom to provide public releases (Right now only accessible by providing strongly protected PATs)

Quality checklist

• [x] I have performed a self-review of my code.

Future Ideas

• Would be nice if these providers can be classes that extend from an abstract class
• We will look into more generic selectors (like proxying getByText, ... for accessing more generic things in dialogs)
• Typescript support

[neuodev]

Hello, @maximgeerinck 👋

If I am getting it correctly this Phantom Wallet support PR is not finished because there is no way to download phantom wallet as it's not open-source. The plan from your side was to wait until it is open-sourced.

Just want to let you know that you can use this chrome extension to extract the source code from any chrome extension as ZIP file.

Also, you can use this website to download the source code.

Also, check this GitHub gist on how to download the source code for any Chrome extension.

CRX Viewer will allow you to download the source code for any Chrome extension (repo)

Thanks, please let me know if you need any help!

[maximgeerinck]

We've added a way to download a phantom crx and install it

[neuodev]

@maximgeerinck Tests are failing due to the recent changes (mostly adding new networks), can you please take a look? Many thanks for considering my request.

[maximgeerinck]

@maximgeerinck Tests are failing due to the recent changes (mostly adding new networks), can you please take a look? Many thanks for considering my request.

Hey, tried testing, it fails on enabling test networks for metamask but it seems to be passing. How do you usually run this cause you're skipping setup? if i don't skip setup it seems to work

[drptbl]

Hey guys, just wanted to let you know that starting from next month we'll have full time dev working on synpress. I will make sure to prioritise merging this asap. Thanks for understanding. Cheers!

[Wgil]

@drptbl those are great news. Do you have any ETA to make synpress wallet agnostic? I would be really interested on using it to test e2e Dapps based on Cosmos chains with wallets like Keplr, Cosmostation or leap wallet

[drptbl]

@drptbl those are great news. Do you have any ETA to make synpress wallet agnostic? I would be really interested on using it to test e2e Dapps based on Cosmos chains with wallets like Keplr, Cosmostation or leap wallet

No ETA, but it should happen within next ~2 months max. We're currently working on adding a plugin system to synpress for wallets (so that each wallet support can be placed in separate node module) and Keplr support is coming after that.

[safaiyeh]

GM! Appreciate the initiative @maximgeerinck, we need this at Magic Eden as well. Let's chat? My email is [email protected] would love to see where we can help.

[duckception]

Hey Phantom team! 👋

I'm the new hire that @drptbl mentioned.

Let's get this PR merged, shall we? I'll post an initial review ~~at the beginning of next week~~. In the meantime, could you @maximgeerinck rebase it to the latest changes on our dev branch?

[duckception]

Two crucial things:

• MetaMask tests are broken. They need to be fixed. Once this is done, I'll approve workflows on CI.
• Add similar tests for Phantom.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
synpress	❌ Failed (Inspect)			Jan 26, 2024 3:15pm

[vercel[bot]]

@maximgeerinck is attempting to deploy a commit to the Synpress Team on Vercel.

A member of the Team first needs to authorize it.