Max Marrone

Results 72 comments of Max Marrone

I don't have a robot in front of me to test, but I'm 90% sure that this isn't a problem anymore.

@sigmavirus24 Thanks. To be clear, do you think some of this PR needs to change to reflect that, or were you just commenting to lend context?

Bump. Are any changes needed for this?

Yeah, we definitely want to upgrade Pydantic. (Internal reference: RSS-227) Unfortunately we haven't started that work yet, so there's no branch you could use. We don't have a timeline for...

Sorry for the lack of updates here. Yes, we're working on this in PR #14871. It's not our first priority, though, so I can't promise it will be completed soon.

Latest update: https://github.com/Opentrons/opentrons/pull/14871#issuecomment-2294227559

Yeah, this fundamental interface looks good to me. I agree that we don't want command executors to add notes by emitting `UpdateCommandAction`s or `AddCommandNoteAction`s. In addition to the reasons you...

Hmm, the `alternateDropLocation` thing looks questionable?