travis-sphinx icon indicating copy to clipboard operation
travis-sphinx copied to clipboard

Change target directory for deploys

Open Nate-Wilkins opened this issue 8 years ago • 3 comments

Would it be possible to remove this check?

if sys.argv[-1] == 'deploy':
    print('outdir option not allowed for deploy')
    sys.exit(2)

I'm unable to change the target directory on deploy which seems like a bug. Same with the --source option?

Nate-Wilkins avatar Jul 27 '16 05:07 Nate-Wilkins

Good point Nate, but is there any reason why you/others would need to change the output directory?

The reasoning for the unchangeable location is that I branched travis-sphinx originally from my Rust code, which if you aren't familiar with the language, it's internal documentation toolchain will always build to the target/doc/build dir.

Syntaf avatar Jul 27 '16 17:07 Syntaf

Hmm I guess just more of a convenience. I'm not really using Rust in my project and I guess for more control? Idk up to you :+1: I can submit a PR if you'd like

Nate-Wilkins avatar Jul 28 '16 02:07 Nate-Wilkins

I'll throw it out that you can build to a specific target directory, anywhere you want, but you can't deploy anywhere but that hard coded path.

It seems pretty easy and simple to remove that check and doesn't actually hurt anything from providing those two options for deploy and build

halkeye avatar Jun 16 '17 17:06 halkeye