spksrc icon indicating copy to clipboard operation
spksrc copied to clipboard

Published 20 hours ago • verified publisher icon SynoCommunity

restic rest-server 0.12.1 initial package

Open fgma opened this issue 2 years ago • 13 comments

Description

New package for restic's rest-server:

https://restic.net/ https://github.com/restic/rest-server

Checklist

  • [x] Build rule all-supported completed successfully
  • [x] New installation of package completed successfully
  • [x] Package upgrade completed successfully (Manually install the package again)
  • [x] Package functionality was tested
  • [x] Any needed documentation is updated/created

Type of change

  • [ ] Bug fix
  • [x] New Package
  • [ ] Package update
  • [x] Includes small framework changes
  • [x] This change requires a documentation update (e.g. Wiki)

TODO:

  • [ ] include certificate handling according to https://github.com/SynoCommunity/spksrc/wiki/Service-Support (SERVICE_CERT, SERVICE_CERT_RELOAD)
  • [x] add port to wiki (https://github.com/SynoCommunity/spksrc/wiki/SynoCommunity-Used-Ports)

fgma avatar Jan 04 '23 21:01 fgma

I will add the port to the wiki when I got some feedback if this PR is getting accepted and the port is OK to be used.

I don't use the certificate handling myself but I guess this would be a nice feature for others. Would the syncthing implementation be a good starting point or is this not yet stable enough yet?

fgma avatar Jan 05 '23 11:01 fgma

just added some suggestions.

Another suggestion for the wizard: You could use one multiselect item instead of single select to have individual checkboxes for each option (and not two check boxes for each).

You can find an example in matrix-synapse PR #5399 (this one uses two multiselect items to have additional description for each option, but as you don't have an additional description you can use one multiselect with multiple subitems)

hgy59 avatar Jan 05 '23 20:01 hgy59

I've switched to multiselect. It looks a bit nicer and the internal handling is a bit easier.

fgma avatar Jan 05 '23 21:01 fgma

Updated to current master. Anything else left for me to do here?

fgma avatar Mar 05 '23 15:03 fgma

Thanks much for packaging this! I have been using restic-rest-server already a couple of months on a Synology box with a manual deployment. I now tried the package built in CI and it seems to work fine. Really looking forward to get this PR integrated.

I had to tweak two things manually to better support my usecase. Wanted to bring them up for discussion to see if it makes sense to include them as UI settings.

  1. I'm backing up to an external USB drive, but I could not select volumeUSB1 in the wizard. I was able to change that in /usr/syno/etc/packages/restic-rest-server/installer-variables.
  2. I'm using https with a self signed certificate (public_key and private_key files are located in the backup repository root) and therefore I had to modify /var/packages/restic-rest-server/scripts/service-setup to start the service with --tls. It would be nice if there was an extra field in the wizard to add 'custom' options.

fetzerch avatar Mar 11 '23 09:03 fetzerch

2. I'm using https with a self signed certificate (public_key and private_key files are located in the backup repository root) and therefore I had to modify /var/packages/restic-rest-server/scripts/service-setup to start the service with --tls. It would be nice if there was an extra field in the wizard to add 'custom' options.

This triggers the discussion above to add a file for custom service arguments.

hgy59 avatar Mar 11 '23 09:03 hgy59

Updated to current master. Anything else left for me to do here?

see #5649 for shared folder handling.

probably this will solve the use case to use an usb drive for backups (when creating a shared folder on the usb drive before the installation of restic rest-server and chosing this share in the wizard).

hgy59 avatar Mar 11 '23 09:03 hgy59

I'll add support for additional custom arguments.

Concerning the certificates: Shouldn't we use SERVICE_CERT/SERVICE_CERT_RELOAD for this use case?

fgma avatar Mar 12 '23 10:03 fgma

Concerning the certificates: Shouldn't we use SERVICE_CERT/SERVICE_CERT_RELOAD for this use case

Does this work for DSM 6 only? #5117 and #5118

hgy59 avatar Mar 12 '23 17:03 hgy59

I have no idea. I don't use it. I've just read about it in the documentation and thought this the proper way to handle certificates.

fgma avatar Mar 12 '23 18:03 fgma

Custom arguments added. What about certificate handling? Is there an official way to do so?

fgma avatar Mar 15 '23 21:03 fgma

Any chance you could retrigger a build, I would like to try it out using the packages (but they're gone).

fetzerch avatar Jan 21 '24 17:01 fetzerch

@fgma can you repase this PR? It is not possible to trigger the gh-build-action again.

hgy59 avatar Jan 21 '24 19:01 hgy59