SIRF icon indicating copy to clipboard operation
SIRF copied to clipboard

Are these uses of boost deprecated?

Open Imraj-Singh opened this issue 1 month ago • 1 comments

I was having a few issues building so changed this line: https://github.com/SyneRBI/SIRF/blob/0ba22c9b5d8b6c2f008e0b1e1846c059703a88c3/src/xGadgetron/cGadgetron/include/sirf/Gadgetron/gadgetron_client.h#L377 to boost::asio::io_context io_service;

Also here: https://github.com/SyneRBI/SIRF/blob/0ba22c9b5d8b6c2f008e0b1e1846c059703a88c3/src/xGadgetron/cGadgetron/gadgetron_client.cpp#L155C1-L156C69 to auto const results = resolver.resolve(hostname, port);

and: https://github.com/SyneRBI/SIRF/blob/0ba22c9b5d8b6c2f008e0b1e1846c059703a88c3/src/xGadgetron/cGadgetron/gadgetron_client.cpp#L176 to oost::asio::connect(*socket_, results, error);

I don't need gadgetron so didn't test, but I was able to build once these were changed.

Imraj-Singh avatar Nov 17 '25 23:11 Imraj-Singh

Boost is moving on for sure. Which version of boost did you use?

I think your second link to modified code is wrong, can you check it?

Maybe it's easiest to do a PR with your mods. We'd then need to guard mods with boost version info, but @evgueni-ovtchinnikov could take care of that.

It might also be checking if we're still roughly up-to-date with https://github.com/gadgetron/gadgetron/blob/master/apps/clients/gadgetron_ismrmrd_client/gadgetron_ismrmrd_client.cpp, which is where I think a lot of this came from. Of course, gadgetron is no longer maintained, so probably not...

KrisThielemans avatar Nov 18 '25 12:11 KrisThielemans