SIRF icon indicating copy to clipboard operation
SIRF copied to clipboard
verified publisher icon SyneRBI

[epic] array views

Open casperdcl opened this issue 6 months ago • 4 comments

One place to keep track of dependencies

  • [ ] https://github.com/SyneRBI/SIRF/pull/1313 @evgueni-ovtchinnikov
    • [x] https://github.com/UCL/STIR/pull/1549
  • [ ] ~https://github.com/SyneRBI/SIRF/pull/1318~ #1332 @evgueni-ovtchinnikov
    • [x] https://github.com/SyneRBI/SIRF/pull/1314 @casperdcl
      • [x] https://github.com/SyneRBI/SIRF/pull/1317 @casperdcl
      • [x] https://github.com/UCL/STIR/pull/1592 @KrisThielemans
  • [ ] bonus: #1305 @Imraj-Singh (depends on #1314)

casperdcl avatar Jun 10 '25 13:06 casperdcl

Not sure where #1340 fits into this, but it has been merged. @evgueni-ovtchinnikov what are the next steps now?

KrisThielemans avatar Oct 07 '25 10:10 KrisThielemans

I wanted to merge #1332 next, but having returned from holidays I found to my dismay that GadgetronDataView objects no longer work - I am getting weird error messages. The only reason for that I can imagine is a change in numpy version (I have now 2.1.3 on my VM, and unfortunately I did not care to ever check numpy version before, so cannot go back to Status Quo).

evgueni-ovtchinnikov avatar Oct 07 '25 10:10 evgueni-ovtchinnikov

Move to #1313 first then? I'm not sure how many conflicts there would be between those 2, but the PET data is currently the most urgent.

KrisThielemans avatar Oct 07 '25 13:10 KrisThielemans

Actually, #1313 is obsolete now that in #1340 we finally found a way to improve the performance of templates so that we could get rid of macros and repetitive code without compromising the performance.

evgueni-ovtchinnikov avatar Oct 07 '25 17:10 evgueni-ovtchinnikov