SIRF-SuperBuild icon indicating copy to clipboard operation
SIRF-SuperBuild copied to clipboard

Error building Tomophantom

Open NicoleJurjew opened this issue 1 year ago • 6 comments

When I try to build with build CIL = ON, I get an error. This seems to be from Tomophantom.

NicoleJurjew avatar Oct 02 '24 16:10 NicoleJurjew

The error said something about cannot find msvc compiler...

I see that Tomophantom has move on dramatically now. Should we update it? Or should we even include it? Currently, it is enabled via BUILD_CIL. Might need a separate BUILD variable then.

KrisThielemans avatar Oct 03 '24 09:10 KrisThielemans

But we are using a specific version, despite the package changes. https://github.com/SyneRBI/SIRF-SuperBuild/blob/5f1a7f498bf6f41551c19eb53798b5d33af43eec/version_config.cmake#L127

@NicoleJurjew can you post the whole error? And how it comes about?

paskino avatar Nov 22 '24 17:11 paskino

We do have a frozen version, which is good, but it is old and OS/compilers etc move on, which possibly caused this problem.

I'm not sure how easy it will be for @NicoleJurjew to reproduce this now (and how much time she has for it!). @NicoleJurjew can you just give OS, CMake and gcc version?

In any case, I think it'd be good to be able to switch-off building of TomoPhantom, independent of CIL.

KrisThielemans avatar Nov 22 '24 18:11 KrisThielemans

Should we discuss whether to include TomoPhantom and CCPi-Regularisation as dependencies of CIL? https://github.com/SyneRBI/SIRF-SuperBuild/blob/c5251d17dc2a4a612bc4b4247b07704d4ccb448b/SuperBuild.cmake#L314

Potentially we could add a BUILD_TomoPhantom etc to force the build.

paskino avatar May 06 '25 12:05 paskino

sure. I thought you needed it for the CIL-demos, but by all means, make it optional.

KrisThielemans avatar May 06 '25 20:05 KrisThielemans

See https://github.com/TomographicImaging/CIL-Demos/issues/254

paskino avatar Jul 08 '25 14:07 paskino