Error building Tomophantom
When I try to build with build CIL = ON, I get an error. This seems to be from Tomophantom.
The error said something about cannot find msvc compiler...
I see that Tomophantom has move on dramatically now. Should we update it? Or should we even include it? Currently, it is enabled via BUILD_CIL. Might need a separate BUILD variable then.
But we are using a specific version, despite the package changes. https://github.com/SyneRBI/SIRF-SuperBuild/blob/5f1a7f498bf6f41551c19eb53798b5d33af43eec/version_config.cmake#L127
@NicoleJurjew can you post the whole error? And how it comes about?
We do have a frozen version, which is good, but it is old and OS/compilers etc move on, which possibly caused this problem.
I'm not sure how easy it will be for @NicoleJurjew to reproduce this now (and how much time she has for it!). @NicoleJurjew can you just give OS, CMake and gcc version?
In any case, I think it'd be good to be able to switch-off building of TomoPhantom, independent of CIL.
Should we discuss whether to include TomoPhantom and CCPi-Regularisation as dependencies of CIL? https://github.com/SyneRBI/SIRF-SuperBuild/blob/c5251d17dc2a4a612bc4b4247b07704d4ccb448b/SuperBuild.cmake#L314
Potentially we could add a BUILD_TomoPhantom etc to force the build.
sure. I thought you needed it for the CIL-demos, but by all means, make it optional.
See https://github.com/TomographicImaging/CIL-Demos/issues/254