VM creation sequence

[KrisThielemans]

We have an interesting circular thing going on now that the VM code is part of this repo. We need to tag the SIRF-SuperBuild before creating a VM, but we might need to fix things before tagging. The chain is

1. A new VM is created via https://github.com/SyneRBI/SIRF-SuperBuild/blob/ec4b9c50bb650101e232590405c06eaf417256a6/VirtualBox/vagrant/Vagrantfile#L99
2. which calls UPDATE.sh (currently with the wrong branch) https://github.com/SyneRBI/SIRF-SuperBuild/blob/ec4b9c50bb650101e232590405c06eaf417256a6/VirtualBox/scripts/bootstrap_ubuntu.sh#L82
3. and UPDATE.sh defaults to using the latest tag https://github.com/SyneRBI/SIRF-SuperBuild/blob/ec4b9c50bb650101e232590405c06eaf417256a6/VirtualBox/scripts/UPDATE.sh#L177-L181

It seems that we need to create it first with a locally modified Vagrantfile that sets -t origin/master, do all the tests, tag, and then recreate.

@paskino any better ideas?

PS: I do think that UPDATE.sh still needs to default to using the latest tag, as this is what update_VM.sh will use.

[paskino]

I think this is what I generally do, anyway

[KrisThielemans]

item 2 "wrong tag" is no longer relevant. https://github.com/SyneRBI/SIRF-SuperBuild/blob/8ca50676b4b3140beb960dc76f2f6ef5d2468ba4/VirtualBox/scripts/bootstrap_ubuntu.sh#L99

[paskino]

We discussed that the SuperBuild code could be copied into the VM at creation time, similarly to how it is done in Docker.