SIRF-SuperBuild icon indicating copy to clipboard operation
SIRF-SuperBuild copied to clipboard

DISABLE_GIT_CHECKOUT_SIRF or SIRF_DISABLE_GIT_CHECKOUT

Open KrisThielemans opened this issue 5 years ago • 2 comments

for consistency, I think we should rename DISABLE_GIT_CHECKOUT_SIRF to SIRF_DISABLE_GIT_CHECKOUT.

I guess we could keep the old variable if people think it's required (but at expense of complexity)

@rijobro ?

KrisThielemans avatar Feb 22 '20 20:02 KrisThielemans

hmmm. BUILD_TESTING_SIRF as well...

KrisThielemans avatar Feb 22 '20 20:02 KrisThielemans

Isn't it that we use consistently DISABLE_GIT_CHECKOUT_${proj} for all the dependencies? I'd close this issue.

https://github.com/SyneRBI/SIRF-SuperBuild/blob/ec4b9c50bb650101e232590405c06eaf417256a6/CMake/SetGitTagAndRepo.cmake#L37

paskino avatar Jul 08 '22 13:07 paskino