SIRF-SuperBuild Dis/enable python/matlab support in Gadgetron (needs boost-python)

There seems to be a mistake in Gadgetron's CMake files such that it errors-out if boost-python is not found (as opposed to not building its Python support). So we need to compile this anyway at present.

May 02 '17 06:05 KrisThielemans

we actually already build boost-python. However, we don't test for any boost components when using the system boost.

May 02 '17 07:05 KrisThielemans

we now disable Gadgetron's Python support, so no longer need boost-python. @paskino can you check if we're still building it (note that the list of components to build are in 2 places, one for Windows and one for the rest)

Dec 11 '17 07:12 KrisThielemans

Yes we are building it. For Unix is easy to remove the python module: https://github.com/CCPPETMR/SIRF-SuperBuild/blob/master/SuperBuild/External_Boost_configureboost.cmake#L26 For Windows I don't quite understand where do we set which boost modules to build.

Dec 14 '17 10:12 paskino

For Windows, it is in `External_Boost_buildboost.cmake.

Dec 18 '17 23:12 KrisThielemans

All right, then for windows isn't there already.

Dec 19 '17 10:12 paskino

actually, we have these variables already, e.g. BUILD_GADGETRON_NATIVE_PYTHON_SUPPORT. This means that we'd need to build boost-python, with lots of consequences, such as #56 and https://github.com/gadgetron/gadgetron/issues/550. I suggest we disable BUILD_GADGETRON_NATIVE_PYTHON_SUPPORT for now, and then reassign this issue to v1.1 (or even later).

Dec 21 '17 01:12 KrisThielemans

will disable this for v1.0.

Jan 05 '18 11:01 KrisThielemans

it is disabled, so shifting milestone

Jan 26 '18 12:01 KrisThielemans

removing from a milestone as nobody seems to want this.

May 20 '21 22:05 KrisThielemans