aparapi icon indicating copy to clipboard operation
aparapi copied to clipboard

Published 20 hours ago • verified publisher icon Syncleus

device module unit tests

Open yana2301 opened this issue 7 years ago • 4 comments

yana2301 avatar May 22 '18 10:05 yana2301

I've added @CoreRasurae as a reviewer so he can also contribute any comments as this PR develops.

freemo avatar May 22 '18 17:05 freemo

@yana2301 Hi Yana, I've seen you've removed some integration tests that seem relevant to me... I know they aren't unit tests, but still, integration tests are also useful. Is there a special reason for this removal?

CoreRasurae avatar May 22 '18 18:05 CoreRasurae

@yana2301 I agree with @CoreRasurae . Several tests were removed that were working well.

freemo avatar May 22 '18 18:05 freemo

@yana2301 Hi Iana, please tell me when you have this PR ready for reviewing. I will also want to know your plans regarding the deleted tests.

CoreRasurae avatar May 23 '18 20:05 CoreRasurae