synbiohub icon indicating copy to clipboard operation
synbiohub copied to clipboard

Genbank of a sequence is empty on download

Open JMante1 opened this issue 4 years ago • 4 comments

if you download the genbank of something like BBa_E0040 (https://synbiohub.org/public/igem/BBa_E0040_sequence/1/gb) there is nothing put in the file. This is a problem as plugins assume it is a valid file

JMante1 avatar Sep 11 '20 15:09 JMante1

GenBank is not a valid download type for Sequences. If you use this link, it works:

https://synbiohub.org/public/igem/BBa_E0040/1/gb

Granted, you should get an error message and not an empty file.

cjmyers avatar Sep 11 '20 17:09 cjmyers

It is possible to generate an un-annotated genbank though and we tell all plugins that we send genbank. So we need to consider the implications of this. Especially as people might expect genbank for sequences

JMante1 avatar Sep 11 '20 19:09 JMante1

Maybe, but GenBank really does not make a lot of sense for unannotated sequences. FASTA is the preferred format for that usually. This is also a libSBOLj issue as it does not support conversion of Sequences to GenBank. The way the converter works is takes an SBOLDocument and creates a GenBank record for each root ComponentDefinition in the document. It is unclear how this would be handled by libSBOLj in the case there are no root CDs or if there are some sequences that are not attached to CDs. It could be possible to have it convert every root CD and any additional Sequences not connected to any CD in the document, but that feels a little hacky to me.

cjmyers avatar Sep 11 '20 20:09 cjmyers

Please note that Download GenBank is not an option from the GUI for any object other than CD. The API though clearly is not checking this.

cjmyers avatar Sep 11 '20 20:09 cjmyers