sass-bundle icon indicating copy to clipboard operation
sass-bundle copied to clipboard

Resolve relative sass_root paths earlier

Open wryk opened this issue 1 year ago • 5 comments

Revert SassCssCompiler before #64. Supports relative paths by resolving/prefixing them at extension loading. I don't know if it should be implemented this way (it feels hacky?) but I don't see how it could be better.

What do you think of this change @smnandre ?

Tests are missing because I don't know enough how asset-mapper works to design an integration test for an AssetCompiler. Testing the builder instead would be even more work for me because my dev env doesn't supports the default sass binary from the bundle.

I'll not have more time in the next weeks to work on it, feel free to modify this PR as much as you want.

wryk avatar Mar 11 '24 21:03 wryk

I'll look later this week, no immediate feedback except: i'd still start with a ".sass" check :)

smnandre avatar Mar 12 '24 17:03 smnandre

Yeah sorry, I ignored this part on purpose and I took the conservative choice to only rollback SassCssCompiler. I don't understand the reasoning of the current supports implementation (comparison of two realpaths) but someone might wrote it for a good reason. Because of the missing or broken tests (in my env) I'd rather not prematurely update code not required for relative path support.

wryk avatar Mar 13 '24 14:03 wryk

I mande a PR on your PR with small change suggestions :)

https://github.com/wryk/sass-bundle/pull/1

smnandre avatar Mar 16 '24 02:03 smnandre

Should we merge now? Or is there still any pending work to do?

bocharsky-bw avatar Nov 29 '25 14:11 bocharsky-bw