sass-bundle icon indicating copy to clipboard operation
sass-bundle copied to clipboard

Allow binary version to be configurable

Open weaverryan opened this issue 2 years ago • 3 comments

Currently, we hardcode the version of the binary that we download. Added this as a configuration option probably makes sense. (This is also true for https://github.com/SymfonyCasts/tailwind-bundle)

weaverryan avatar Aug 18 '23 19:08 weaverryan

Hi @weaverryan, I'd be happy to give a go at implementing this, (if satisfactory also for the tailwind bundle).

Do you already have some idea on how you would like to do this? Would you like to have a list of supported versions and check beforehand? or merely failing with a 'you probably have a wrong version configured' message if the binary request in SassBinary::downloadExecutable fails?

dorxy avatar Dec 09 '23 18:12 dorxy

or merely failing with a 'you probably have a wrong version configured' message if the binary request in SassBinary::downloadExecutable fails?

Yup, this :D. If you give us the version, we use that in the URL instead of https://github.com/SymfonyCasts/sass-bundle/blob/main/src/SassBinary.php#L19 and if it fails, it fails.

So yes please! And on both bundles would be wonderful ❤️

weaverryan avatar Dec 09 '23 19:12 weaverryan

There's a related PR for TailwindBundle: https://github.com/SymfonyCasts/tailwind-bundle/pull/34

bocharsky-bw avatar Dec 14 '23 17:12 bocharsky-bw