mapdeck icon indicating copy to clipboard operation
mapdeck copied to clipboard

Mobile Support

Open dcooley opened this issue 5 years ago • 10 comments

First posted here - https://stackoverflow.com/questions/64045451/mapdeck-with-shiny-mobile

And the related RFC - https://github.com/visgl/deck.gl/blob/master/dev-docs/RFCs/proposals/mobile-platform-support-rfc.md

dcooley avatar Sep 24 '20 22:09 dcooley

for testing, try the add_grid() layer with gpu_aggregation = FALSE argument

remotes::install_github("SymbolixAU/mapdeck", ref = "issue325")

dcooley avatar Sep 24 '20 22:09 dcooley

Adding gpu_aggregation = FALSE on the server side gives error: unused argument.

Following is the code on server side:

output$myMap <- renderMapdeck({
      data_filter$val <- sample(1:10, size = nrow(data_filter), replace = T)
      mapdeck( style = mapdeck_style("dark"), pitch = 55, zoom = 4) %>%
        add_grid(
          data = data_filter
          , lat = "lat"
          , lon = "lng"
          , layer_id = "hex_layer"
          , elevation_scale = 1
          , elevation_function = "mean"
          , elevation = "val"
          , colour = "val"
          ,gpu_aggregation = FALSE
          ,cell_size = 10
        ) %>%
        add_heatmap(
          data = data_filter
          , weight = "val",
          layer_id = "heatmap_layer"
        )
    })

931nayyer avatar Sep 25 '20 06:09 931nayyer

Have you installed the dev version using the remotes::install_github("SymbolixAU/mapdeck", ref = "issue325") code I gave?

This works for me

mapdeck() %>%
  add_grid(
    data = roads
    , gpu_aggregation = FALSE
)

dcooley avatar Sep 25 '20 06:09 dcooley

I am really excited to see Cooley getting involved to resolve! I have tried remotes::install_github("SymbolixAU/mapdeck", ref = "issue325") but it is giving me following error:

ERROR: failed to lock directory 'C:/Users/User/Documents/R/win-library/3.6' for modifying Try removing 'C:/Users/User/Documents/R/win-library/3.6/00LOCK-mapdeck' Error: Failed to install 'mapdeck' from GitHub: (converted from warning) installation of package ‘C:/Users/User/AppData/Local/Temp/Rtmp0IjOSm/file1a54331e1a33/mapdeck_0.3.4.tar.gz’ had non-zero exit status

931nayyer avatar Sep 25 '20 06:09 931nayyer

You may need to re-start your R session before installing it. And also "Try removing 'C:/Users/User/Documents/R/win-library/3.6/00LOCK-mapdeck'"

dcooley avatar Sep 25 '20 07:09 dcooley

Hi Cooley, Thanks for your time! I could install dev version using the code you gave. I have rendered the shiny app but the issue seems unresolved. 2.5D View in tab-5 of following rendered app shows the grid and heatmap perfectly but on my mobile phone they don't appear:

931nayyer avatar Sep 25 '20 08:09 931nayyer

Then I'm not sure how much I can help as I think this is related to the hardware and / or browser on the mobile device.

dcooley avatar Sep 27 '20 23:09 dcooley

Hi Dave, Yes I agree with you , nothing much can be done. In my opinion the issue is with 'Framework7' in ShinyMobile package. Last year I had similar issues when I tried leaflet package with F7 and leaflet pop-ups didn't work in mobiles, though worked fine in laptops/ desktops. Anyhow thanks for your time and efforts. You developed a super-cool package and I really felt honored to work with you on this issue. I was so excited that I told my whole family and friends that I am working with Dave for some testing. thanks again!

931nayyer avatar Sep 28 '20 05:09 931nayyer

This might get solved in Deck.gl v8.3 - https://github.com/visgl/deck.gl/issues/4998#issuecomment-706298106

When 8.3 is release I'll merge it into here and we / you can test this again.

dcooley avatar Oct 12 '20 21:10 dcooley

Thanks Dave, I will be glad to be part of testing. Regards

On Tue, Oct 13, 2020, 1:29 AM Dave [email protected] wrote:

This might get solved in Deck.gl v8.3 - visgl/deck.gl#4998 (comment) https://github.com/visgl/deck.gl/issues/4998#issuecomment-706298106

When 8.3 is release I'll merge it into here and we / you can test this again.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/SymbolixAU/mapdeck/issues/325#issuecomment-707354839, or unsubscribe https://github.com/notifications/unsubscribe-auth/AREJ4WRGXEFKQZKF7E4CTETSKNYLBANCNFSM4RY2YUQA .

931nayyer avatar Oct 19 '20 17:10 931nayyer