DynamicExpressions.jl icon indicating copy to clipboard operation
DynamicExpressions.jl copied to clipboard

remove default zero(UInt) from hash seed

Open adienes opened this issue 2 months ago • 2 comments

this creates a 1-arg method Base.hash(:: AbstractExpressionNode{T}) morespecific than the default hash(::Any) fallback, and since the default seed is not 0 anymore this leads to hash inconsistencies and bugs.

adienes avatar Oct 08 '25 14:10 adienes

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 96.84%. Comparing base (d4b12df) to head (0e15bc1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #141      +/-   ##
==========================================
+ Coverage   96.67%   96.84%   +0.17%     
==========================================
  Files          30       30              
  Lines        2614     2602      -12     
==========================================
- Hits         2527     2520       -7     
+ Misses         87       82       -5     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Oct 08 '25 18:10 codecov[bot]

Thanks.

Other issues seem to be related to Julia 1.12.0

MilesCranmer avatar Oct 08 '25 19:10 MilesCranmer