FedScale icon indicating copy to clipboard operation
FedScale copied to clipboard

[Example/Notebook] Jupyer Notebook Server and Client Example Contain Old Code Leads Error

Open mtang724 opened this issue 1 year ago • 2 comments

What happened + What you expected to happen

In FedScale/examples/notebook, the server and client contain old code "from fedscale.core.logger.execution import args" which suppose to be in new form "import fedscale.core.config_parser as parser" -> args = parser.args

Versions / Dependencies

FedScale 0.5, pip install -e .

Reproduction script

It happened when I tried to run the example code in jupyter notebook after installation. So it would be great to fix it to not to confuse new users.

Issue Severity

Low: It annoys or frustrates me.

mtang724 avatar Oct 05 '22 03:10 mtang724

@IKACE Can you please fix this due to the last commit? #175 Thanks!

fanlai0990 avatar Oct 05 '22 04:10 fanlai0990

Thank you for catching this bug! I've submitted a fix PR to the master branch.

IKACE avatar Oct 05 '22 15:10 IKACE