FedScale icon indicating copy to clipboard operation
FedScale copied to clipboard

Redis Support for FedScale

Open xuyehe opened this issue 2 years ago • 2 comments

Why are these changes needed?

To integrate Redis into aggregator for saving aggregation data.

Related issue number

N/A

Checks

  • [x] I've included any doc changes needed for https://fedscale.readthedocs.io/en/latest/
  • [x] I've made sure the following tests are passing.
  • Testing Configurations
    • [x] Dry Run (20 training rounds & 1 evaluation round)
    • [x] Cifar 10 (20 training rounds & 1 evaluation round)
    • [x] Femnist (20 training rounds & 1 evaluation round)

Note:

  1. All tests are run on cpu.
  2. Met with the following KeyError bug on the same line in Femnist once with Redis, and also once without Redis (i.e. original code). Sample error output:
File "/users/xuyehe/FedScale-rd/fedscale/core/aggregation/aggregator.py", line 386, in client_completion_handler
    duration=self.virtual_client_clock[results['clientId']]['computation'] +
KeyError: 665

xuyehe avatar Aug 23 '22 23:08 xuyehe

Thanks a lot for your contribution! Let's try to run an e2e evaluation to validate the learning curve and Redis overhead first.

fanlai0990 avatar Aug 26 '22 06:08 fanlai0990

Thanks for your contribution. Can you please

  • remove all prints or replace them with logging.info
  • summarize the results of the overhead analysis

We really appreciate your help.

fanlai0990 avatar Oct 12 '22 08:10 fanlai0990