Improve RDNA 3.0 information presentation

[birdie-github]

Since the video encoding/decoding pipeline for RDNA 3.0 is now unified could you change the title from ENC, to e.g. VID (Video Engine) or ENC/DEC? People will continue to be confused and will keep on filing bug reports.

Actually I don't see the reason to shorten ENCODING or DECODING to ENC or DEC.

There's a ton of space to print the entire string, e.g. VIDEO ENGINE.

Thank you!

[meminens]

I am glad I came across with this issue. I have been wondering why ENC column shows activity when I play a video in Firefox with hardware acceleration enabled.

[Umio-Yasuno]

@Syllo

AFAIK, RDNA 3 dGPU is AMDGPU_FAMILY_GC_11_0_0. Will this commit work? (Sorry, I can't test it because I dont't have RDNA 3 GPU)
Phoenix APU (AMDGPU_FAMILY_GC_11_0_1) also has VCN4 similar to RDNA 3 dGPU.

https://github.com/Syllo/nvtop/commit/4989f313284fbbe6e470c5bfb142acca770176b0

[Syllo]

@Umio-Yasuno, thanks for pointing that out.

By looking at the kernel source code of amdgpu discovery it seems that I cannot rely solely on the family being >= of AMDGPU_FAMILY_NV) since Navi got released with RDNA 2 and RDNA 3.

Any of you knows if testing the IP version >= 10.3 (https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c#L2412) would be correct? I can query that using a drm AMDGPU_INFO_HW_IP_INFO query.

[Umio-Yasuno]

I think checking the major version of VCN_ENC using amdgpu_query_hw_ip_info with AMDGPU_HW_IP_VCN_ENC is helphul.

    drm_amdgpu_info_hw_ip vcn_ip_info = {0};
    int r = amdgpu_query_hw_ip_info(
        amdgpu_dev,
        AMDGPU_HW_IP_VCN_ENC,
        0,
        &vcn_ip_info
    );
    ...
   
    4 <= vcn_ip_info.hw_ip_version_major

    ...

[Syllo]

I just pushed the patch to master (tested on VCE version 1 though) but it should now detect shared Enc+Dec on version >= 4.