SyliusCrafts
[WIP][PoC] add behat to github actions
| Q | A |
|---|---|
| Branch? | master |
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | yes |
| Deprecations? | yes |
| Related tickets | partially #60 |
| License | MIT |
Please keep in mind that currently when you run behat, you're just running the tests against the standard sylius version, without the theme, as that is controlled in the scenarios themselves. I don't see any code where you're overriding anything to make sure the right theme is selected for the channel that is used in the tests, or are somehow updating the channel that is added by the tests.
Also wouldn't it be good to run the tests in the container setup? That way development and testing can be done in the exact same environment, no matter what system is being used... Preventing the whole "works on my machine" syndrome.
Hello @4c0n
Thanks for feedbacks.
Please keep in mind that currently when you run behat, you're just running the tests against the standard sylius version, without the theme, as that is controlled in the scenarios themselves. I don't see any code where you're overriding anything to make sure the right theme is selected for the channel that is used in the tests, or are somehow updating the channel that is added by the tests.
I forced sylius/bootstrap-theme in step :
https://github.com/Sylius/BootstrapTheme/pull/71/files#diff-cdce82e9a7520e499cfed0c6b68a24a25fe1ed5613d70f6777a2eb95aceabc17R138
Do you have a better solution ?
Also wouldn't it be good to run the tests in the container setup? That way development and testing can be done in the exact same environment, no matter what system is being used... Preventing the whole "works on my machine" syndrome.
We can do that, yes. But I would like to make them work like this already, and then we can use a custom container. It suits you ?
Regards,
@oallain ah I missed that part. Someone came up with this solution: https://gist.github.com/anthid/dcc214804354c8d81013453d83aa219f I think there is or was also a PR he made for this, but I can't find it right now.
Sure the containers can come later.