SyliusResourceBundle icon indicating copy to clipboard operation
SyliusResourceBundle copied to clipboard

Suppressing exceptions caught in the pipeline might lead to undefined behavior

Open kachayev opened this issue 5 years ago • 0 comments

Both server and client handlers simply log all caught exceptions. In case something goes wrong in the pipeline, processing might be stuck. E.g. when a server responds unexpectedly, Netty throws io.netty.handler.codec.EncoderException making the connection effectively useless. I'm not sure what is the best approach handling exceptions for the server, but at least for the client we probably need to clean up (close connection?) or propagate exception as the request result.

kachayev avatar Dec 18 '18 23:12 kachayev