SyliusMailerBundle icon indicating copy to clipboard operation
SyliusMailerBundle copied to clipboard

Published 20 hours ago • verified publisher icon Sylius

Ability to define attachment filename

Open adpeyre opened this issue 2 years ago • 3 comments

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT

adpeyre avatar Jun 08 '22 08:06 adpeyre

Merge and release soon ? :)

adpeyre avatar Jun 14 '22 08:06 adpeyre

My colleagues might ask for a test, but let's find it out. @Zales0123 WDYT about this one?

vvasiloi avatar Jun 14 '22 08:06 vvasiloi

Hello @adpeyre 🖖 Yes, covering it with tests would be needed. Not only unit tests (PHPSpec) but also functional (as we already have them introduced). Moreover, as we already have support for SymfonyMailer as well, we would need to add such a feature in this adapter too.

But the feature proposal itself is nice 👌 Let me know if you need any help 🚀

Zales0123 avatar Jun 23 '22 07:06 Zales0123