ShopApiPlugin icon indicating copy to clipboard operation
ShopApiPlugin copied to clipboard

Shop API for Sylius.

Results 51 ShopApiPlugin issues
Sort by recently updated
recently updated
newest added

CartBlamer's purpose is to be called on each request by authenticated customer and in case current request is one of `/carts/{token}` requests, then attach current customer to the cart. This...

Bug

itemsTotal contains discounted price, I assume this should show totalPrice without discount, as we have discounted price in total? ``` { "tokenValue": "586e28d4-7d47-41b7-9fba-cb07ae0ba5c0", "channel": "HR_SPLIT", "currency": "EUR", "locale": "en_US", "checkoutState":...

Unconfirmed Bug

https://github.com/Sylius/ShopApiPlugin/blob/3ace12724f53c330d6b894fe2bbe639ecc140d76/src/Handler/Cart/AssignCustomerToCartHandler.php#L42 `AssignCustomerToCartHandler` uses `ShopUserAwareCustomerProvider`, which uses `loggedInShopUserProvider`. That makes `AssignCustomerToCartHandler` stateful by depending to currently logged in user. I think this is not optimal and should be avoided the same...

RFC
Maintenance
BC Break

I am wondering if extracting error handling of exceptions like `ChannelNotFoundException` as generic approach for the shop api would be suitable. At the moment every resource handles on its own...

RFC

## Problem Some controllers currently missing proper validation with the Symfony validator component. This results in uncaught exceptions from the `Assert`s in the handlers which will end in a `500`...

Minor
Maintenance

I've encountered two cases, but codebase needs to be grepped for more. https://github.com/Sylius/ShopApiPlugin/blob/master/src/ViewRepository/Product/ProductCatalogViewRepository.php#L88 https://github.com/Sylius/ShopApiPlugin/blob/master/src/ViewRepository/Product/ProductLatestViewRepository.php#L61

Bug

Hey everyone, To add a simple field to the address entity and save it with the /checkout/{token}/address i'm required to completely overwrite about 10 files. This is mostly because many...

Right now `PutVariantBasedConfigutableItemToCartRequest` only perform very simple [check](https://github.com/Sylius/ShopApiPlugin/blob/master/src/Resources/config/validation/cart/PutVariantBasedConfigutableItemToCartRequest.xml) May I know is it intentional to leave it availability checking out?

Bug
Documentation
Maintenance

Hi, currently the shipping / billing addresses of a cart are not validated during addressing. You have code in it that is supposed to do it but it does not...

Bug
Minor

**Sylius version affected**: 1.6.4 **Description** I'm making a promotion of 50% in product. Promotions with fixed discount in product works ok but percentage discount in product calculates wrong the amount...