Contribute-To-This-Project icon indicating copy to clipboard operation
Contribute-To-This-Project copied to clipboard

Published 20 hours ago • verified publisher icon Syknapse

Continuous Integration/prettier Issue

Open micahweston opened this issue 3 years ago • 3 comments

When PRs are made with CI. If the PR is not made from the forked master branch CI will not be able to find file, and not pass.

Suggested fix for issue:

  • Possible change in instructions for submitting pull request.
  • Is there anything we can do to change settings for CI to make sure it can find branches of forks? CI issue #987 CI issue passed #988

micahweston avatar Sep 24 '21 19:09 micahweston

I confirm waht micahweston discovered, If you create a PR from master it pass the checks, if the PR is from the branch it does not pass.

In my opinion is makes sense to create the PR from the branch and not from master. This way is how We usually do it in my workplace. Is this the common way?

moonbe77 avatar Sep 25 '21 09:09 moonbe77

Or we could just manually update the HTML file (which is what I did for some of the cards using CTRL + K + F in vscode)

win21H2 avatar Jul 24 '22 07:07 win21H2

Having an automated way to make sure the project consistently remains organised by prettier, especially after being forked and submitted by a contributor would be a big advantage. It is an area that would be worth investing time in to figure out how to solve and improve.

Syknapse avatar Jul 26 '22 05:07 Syknapse

closing the issue: the project has pre-commit prettier configuration now.

TenTraicion avatar Jun 14 '23 06:06 TenTraicion