Diveni icon indicating copy to clipboard operation
Diveni copied to clipboard

Styling of AnalyticsComponent

Open 123noahB opened this issue 2 years ago • 3 comments

Changed the styling similar to the boxes above.

123noahB avatar Oct 25 '23 14:10 123noahB

Hey @123noahB , looks really good 👍. Thanks for your contribution. While we're at it, what do you think about moving all the inline styles for the text alignments into a separate class and then applying that class to all the b-card-text sub-components? 😃 Also you could just simply add text-align: center; to our .statsCards {...} and remove all text alignment inline styles. This would make it even easier to modify and maintain the appearance of the page in the future.

Dan1elBox avatar Oct 26 '23 08:10 Dan1elBox

Hey @Dan1elBox , i moved the text-align into stats-cards. I tried to change the rest but it didn't work, either the line or tilte moved. I hope it's ok like it is now.

123noahB avatar Oct 30 '23 08:10 123noahB

@123noahB could you fix the lint errors please: https://github.com/Sybit-Education/Diveni/actions/runs/6689791281/job/18183010772?pr=487

Could be done by running npm run lint:fix locally at frontend directory.

stritti avatar Oct 30 '23 12:10 stritti