Update Cmd palette icon based on user's OS
Context Command palette support was added in #14 #102.
There are a few minor shortcomings with it, though:
- The tooltip text says, "Open command palette (CMD+k)". Although the text says 'CMD', the code actually uses [Meta Key] + k, where Meta Key is CMD on mac or WINDOWS KEY on windows. Without knowing that, however, Windows users might suspect that the command palette only works for mac users.
- The cmd palette wasn't tested on Windows I'm on Mac and have never tested that the command palette works on Windows.
Tasks
- [ ] Update tooltip text so that it shows "{Cmd} + k" for mac users and "{Win} + k" for windows users*, where {Cmd} and {Win} refer to the icons
If you're a Windows user:
- [ ] Test it works on Windows and post a comment here to confirm
Implementation Guidance
Update MetaKey.tsx
See icon prop in the react-cmdk ListItem API
See the 'custom' section below for an example of how to use navigator.platform to accomplish this
https://github.com/albingroen/react-cmdk
Can take that one
Thanks for your willingness to help out, @MrPand-21. Unfortunately this is a Q4 issue, so it won't be worked on until September 2025 at the earliest. Please find an issue with the Q1 or Q2 milestone instead. I just created a new view to make that easier to do: https://github.com/orgs/SwitchbackTech/projects/4/views/8
Here is the updated workflow for picking up issues: https://docs.compasscalendar.com/docs/contribute/#workflows
Title is a little misleading, since the Cmd Palette actions already have icons. Will update the title based on the description of the ticket.
Hey! I’m a full stack dev comfortable with React and TypeScript. I use both Windows and macOS, so I can handle updating the tooltip icon and verify the behavior on both systems. I can get it done in the next 24–48 hours.
@sonkiee Sure! All yours.
Unassigning and moving back to Ready due to inactivity
I can try this one if it's available!
@fogboots Sounds good, just submit a PR whenever it's ready!
Since you're a new contributor, we will NOT assign the issue to you before a PR is submitted. This helps us avoid holding an issue for an extended period of time.
https://docs.compasscalendar.com/docs/contribute/
CC @that-one-arab
closed in https://github.com/SwitchbackTech/compass/pull/547